Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move ngIndia 2020 to past events on events page #35901

Closed
wants to merge 1 commit into from
Closed

docs: move ngIndia 2020 to past events on events page #35901

wants to merge 1 commit into from

Conversation

ajitsinghkaler
Copy link
Contributor

ng india was an outdated event removed it from upcoming events on the events page and added to already presented events

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

ngIndia is in upcoming events. Its already completed

Issue Number: N/A

What is the new behavior?

Added ng India to already presented events

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from IgorMinar March 6, 2020 09:18
@gkalpak gkalpak requested review from gkalpak and removed request for IgorMinar March 6, 2020 13:06
@gkalpak gkalpak added comp: docs target: patch This PR is targeted for the next patch release type: bug/fix labels Mar 6, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 6, 2020
@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Mar 6, 2020
gkalpak
gkalpak approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @ajitsinghkaler! Good catch 👍

(I think it would make sense to have a widget that would show the events as upcoming or past depending on their dates and only have a list of events. I remember we have discussed that in the past, but I couldn't find the discussion.)

Can you update the commit message to be more specific. (This helps when scanning going through git history trying to find a particular commit.) E.g.:

docs: move ngIndia 2020 to past events on events page

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Mar 6, 2020
@ajitsinghkaler
docs: move ngIndia 2020 to past events on events page
f7a968a 
ng india was an outdated event removed it from upcoming events on the events page and added to already presented events
@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented Mar 6, 2020 •
edited

@gkalpak made the changes

If I get time I'll try to implement that widget. It will be really helpful if you can tell me about the discussion

@gkalpak gkalpak changed the title docs: updated events page docs: move ngIndia 2020 to past events on events page Mar 6, 2020
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 6, 2020
@gkalpak
Copy link
Member

gkalpak commented Mar 6, 2020

merge-assistance: Global approval for this docs-only change.

matsko pushed a commit that referenced this pull request Mar 6, 2020
@ajitsinghkaler @matsko
docs: move ngIndia 2020 to past events on events page (#35901)
6330200 
ng india was an outdated event removed it from upcoming events on the events page and added to already presented events

PR Close #35901
@matsko matsko closed this in 59078c4 Mar 6, 2020
@ajitsinghkaler ajitsinghkaler deleted the events branch March 9, 2020 10:26
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajitsinghkaler @gkalpak @googlebot